-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cant create a pipeline with error deployment failed #666
Comments
Hello @MATTT-P, thanks for raising an issue. The error log might be a bit misleading as it suggests you to run We are using AWS DDK CLI 0.6.2 as you can see in the logs. In versions <1.0.0 DDK uses the DDK CLI (here are the docs for the CLI documentation) and this is the multi-account implementation that data.all leverages. I hope that helps, please feel free to reach out if you still face issues |
@dlpzx After ddk bootstrapping, using "gitflow" and "CodePipeline - trunk" CICD strategy now CodePipeline runs successfully. But using "CDK - trunk" strategy CodePipeline is not getting created and in dataAll UI pipeline status shows in PENDING state forever. we tried to debug this issue but found that stackID is getting assigned NULL value in case of "CDK - trunk" strategy. In case of other two strategy there was a proper value allocated to stackID. Below is the stack log for CDK - trunk pipeline:
|
Hi @MATTT-P, |
Thanks @louishourcade for looking into the issue. Also, it looks like the deployment was successful, the issue is on the describe stack operation. @MATTT-P can you check if the stack was created in CloudFormation? I think the issue is in |
) ### Feature or Bugfix - Bugfix ### Detail - fix name reference that was using hardcoded "dataall" and instead use environment resource prefix. Solves: #666 ### Relates - <URL or Ticket> ### Security Please answer the questions below briefly where applicable, or write `N/A`. Based on [OWASP 10](https://owasp.org/Top10/en/). - Does this PR introduce or modify any input fields or queries - this includes fetching data from storage outside the application (e.g. a database, an S3 bucket)? - Is the input sanitized? - What precautions are you taking before deserializing the data you consume? - Is injection prevented by parametrizing queries? - Have you ensured no `eval` or similar functions are used? - Does this PR introduce any functionality or component that requires authorization? - How have you ensured it respects the existing AuthN/AuthZ mechanisms? - Are you logging failed auth attempts? - Are you using or adding any cryptographic features? - Do you use a standard proven implementations? - Are the used keys controlled by the customer? Where are they stored? - Are you introducing any new policies/roles/users? - Have you used the least-privilege principle? How? By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
The above solution has been implemented in PR #985 Closing this issue for now as remediated - please do open again or create a new issue if any further issues persist, thanks |
Describe the bug
When creating a new pipeline, no matter which CICD strategy is selected, we are not able to create a pipeline.
The recommended action from the error is to bootstrap but it still persists after bootstrapping.
Error:
How to Reproduce
Create a pipeline.
All 3 of the options produce the same error.
Expected behavior
Pipeline created successfully.
Your project
No response
Screenshots
No response
OS
n/a
Python version
3.7
AWS data.all version
1.5.5
Additional context
No response
The text was updated successfully, but these errors were encountered: