Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create DatasetLock for new datasets #1090

Merged
merged 4 commits into from
Mar 7, 2024
Merged

Conversation

noah-paige
Copy link
Contributor

Feature or Bugfix

  • Bugfix

Detail

  • For new datasets - create a new dataset lock record
    • otherwise shares will timeout and fail since they can not acquire lock

Relates

Security

Please answer the questions below briefly where applicable, or write N/A. Based on
OWASP 10.

  • Does this PR introduce or modify any input fields or queries - this includes
    fetching data from storage outside the application (e.g. a database, an S3 bucket)?
    • Is the input sanitized?
    • What precautions are you taking before deserializing the data you consume?
    • Is injection prevented by parametrizing queries?
    • Have you ensured no eval or similar functions are used?
  • Does this PR introduce any functionality or component that requires authorization?
    • How have you ensured it respects the existing AuthN/AuthZ mechanisms?
    • Are you logging failed auth attempts?
  • Are you using or adding any cryptographic features?
    • Do you use a standard proven implementations?
    • Are the used keys controlled by the customer? Where are they stored?
  • Are you introducing any new policies/roles/users?
    • Have you used the least-privilege principle? How?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dlpzx
Copy link
Contributor

dlpzx commented Mar 6, 2024

Hi @noah-paige I am looking at the test issues ERROR: update or delete on table "dataset" violates foreign key constraint "dataset_lock_datasetUri_fkey" on table "dataset_lock" E DETAIL: Key (datasetUri)=(2ejdgadc) is still referenced from table "dataset_lock". The PR itself looks good, I am surprised we did not catch it before!

@dlpzx
Copy link
Contributor

dlpzx commented Mar 7, 2024

Tested in AWS:

  • new datasets are created with row in dataset_lock (created and imported with SSE-S3 and KMS)
  • shares for these datasets succeed
  • delete dataset deletes row in dataset_lock

Approving and merging!

Copy link
Contributor

@dlpzx dlpzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dlpzx dlpzx merged commit 4a9cc1d into main Mar 7, 2024
8 checks passed
@dlpzx dlpzx deleted the fix/new-dataset-create-lock branch March 26, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants