Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update CDK exec role Policy name with region in template #1197

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

dlpzx
Copy link
Contributor

@dlpzx dlpzx commented Apr 19, 2024

Feature or Bugfix

  • Feature

Detail

  • Adds region as part of the policy name of the CDK exec role
  • Updates cdk bootstrap command accordingly

Backwards compatibility. If not using multi-region, users won't notice any difference because their CDKToolkit will continue working as usual.

  • If at any moment they want to onboard a second environment in the same account, they can create the second environment using the new template without affecting the first cdkToolkit.
  • If they want to use the new template, they can just update their CDK Toolkit and the cdk exec role will be updated (new policy attached). Since no roles are deleted and re-created, users and existing resources (e.g. KMS keys...) won't be impacted.

Testing:

  • Creation of the stack DataallCustomExecRolePolicy stack + creation of CDKToolkit with this stack + creation of second environment

Relates

Security

Please answer the questions below briefly where applicable, or write N/A. Based on
OWASP 10.

  • Does this PR introduce or modify any input fields or queries - this includes
    fetching data from storage outside the application (e.g. a database, an S3 bucket)?
    • Is the input sanitized?
    • What precautions are you taking before deserializing the data you consume?
    • Is injection prevented by parametrizing queries?
    • Have you ensured no eval or similar functions are used?
  • Does this PR introduce any functionality or component that requires authorization?
    • How have you ensured it respects the existing AuthN/AuthZ mechanisms?
    • Are you logging failed auth attempts?
  • Are you using or adding any cryptographic features?
    • Do you use a standard proven implementations?
    • Are the used keys controlled by the customer? Where are they stored?
  • Are you introducing any new policies/roles/users?
    • Have you used the least-privilege principle? How?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dlpzx dlpzx merged commit 8e15729 into main Apr 19, 2024
10 checks passed
@dlpzx dlpzx deleted the fix/add-support-cdk-exec-roles-multi-region-environments branch April 25, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants