Generic shares_base module and specific s3_datasets_shares module - part 2 (db objects to shares_base) #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlpzx
force-pushed
the
feat/generic-dataset-sharing-2-simplified
branch
from
ec2404e to
d78d95f
Compare
dlpzx
changed the title
dlpzx
changed the title
petrkalos
approved these changes
May 22, 2024
| def get_transition_target(self, prev_state): | ||
| if self.validate_transition(prev_state): | ||
| for target_state, list_prev_states in self._transitions.items(): | ||
| if prev_state in list_prev_states: |
There was a problem hiding this comment.
nit: not in and drop the else branch
There was a problem hiding this comment.
I just copy/pasted the code. I was very tempted to do changes on the implementation of the state machines, but I think we should do a review of them in a separate PR
| def __init__(self, name, transitions): | ||
| self._name = name | ||
| self._transitions = transitions | ||
| self._all_source_states = [*set([item for sublist in transitions.values() for item in sublist])] |
There was a problem hiding this comment.
nits
itertools.chain.from_iterable(transitions.values())should flatten your values- why convert the set to list? I guess you want to dedup but why convert back to list?
- by converting to set you assume that the values are hashable, I can see that are enum values so they must be but give it a thought
| self._name = name | ||
| self._transitions = transitions | ||
| self._all_source_states = [*set([item for sublist in transitions.values() for item in sublist])] | ||
| self._all_target_states = [item for item in transitions.keys()] |
There was a problem hiding this comment.
nit: why is this needed? what's wrong with self._all_target_states = transitions.keys()?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Detail
As explained in the design for #1123 and #1283 we are trying to implement generic
datasets_baseandshares_basemodules that can be used by any type of datasets and by any type of shareable object in a generic way.In this PR:
shares_basemodule.Relates
Security
Please answer the questions below briefly where applicable, or write
N/A. Based onOWASP 10.
fetching data from storage outside the application (e.g. a database, an S3 bucket)?
evalor similar functions are used?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.