Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Sagemaker permissions and fix typo #1401

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

noah-paige
Copy link
Contributor

Feature or Bugfix

  • Bugfix

Detail

  • Add permissions for Sagemaker Spaces with no Tag Condition
    • There does not seem to be a way to create a space with tags in AWS SM Studio Console
  • Fix typo in iam policy condition for tag value

Relates

Security

Please answer the questions below briefly where applicable, or write N/A. Based on
OWASP 10.

  • Does this PR introduce or modify any input fields or queries - this includes
    fetching data from storage outside the application (e.g. a database, an S3 bucket)?
    • Is the input sanitized?
    • What precautions are you taking before deserializing the data you consume?
    • Is injection prevented by parametrizing queries?
    • Have you ensured no eval or similar functions are used?
  • Does this PR introduce any functionality or component that requires authorization?
    • How have you ensured it respects the existing AuthN/AuthZ mechanisms?
    • Are you logging failed auth attempts?
  • Are you using or adding any cryptographic features?
    • Do you use a standard proven implementations?
    • Are the used keys controlled by the customer? Where are they stored?
  • Are you introducing any new policies/roles/users?
    • Have you used the least-privilege principle? How?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@noah-paige
Copy link
Contributor Author

Tested changes reflected on update to environment + added permissions to spaces resolves errors starting, stopping, deleting a JupyterLab Space via Studio Console UI

@dlpzx
Copy link
Contributor

dlpzx commented Jul 11, 2024

You are right, according to the docs it is not possible to use tags on the space for the updateSpace action. But for the rest of actions yes. So maybe we can open just updateSpace to all spaces and leave the rest with the tag condition.

With just this block, launch, run space and stop space work fine

        {
            "Action": "sagemaker:UpdateSpace",
            "Resource": [
                "arn:aws:sagemaker:eu-west-1:1111111:space/*"
            ],
            "Effect": "Allow"
        },

@noah-paige noah-paige merged commit b6e6e4b into main Jul 12, 2024
9 checks passed
@dlpzx dlpzx deleted the fix/studio-user-spaces-permissions branch September 11, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants