Metadata forms: List of Attached Forms

[SofiaSazonova]

Feature or Bugfix

• Feature

Detail

• New Tab in MF View
• NO ACCESS RESTRICTION: if entity has an attached form, it's visible in this tab

Relates

• Metadata Form Versioning #1621

Security

Please answer the questions below briefly where applicable, or write N/A. Based on
OWASP 10.

• Does this PR introduce or modify any input fields or queries - this includes
  fetching data from storage outside the application (e.g. a database, an S3 bucket)?
  • Is the input sanitized?
  • What precautions are you taking before deserializing the data you consume?
  • Is injection prevented by parametrizing queries?
  • Have you ensured no eval or similar functions are used?
• Does this PR introduce any functionality or component that requires authorization?
  • How have you ensured it respects the existing AuthN/AuthZ mechanisms?
  • Are you logging failed auth attempts?
• Are you using or adding any cryptographic features?
  • Do you use a standard proven implementations?
  • Are the used keys controlled by the customer? Where are they stored?
• Are you introducing any new policies/roles/users?
  • Have you used the least-privilege principle? How?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[noah-paige]

One bug I see - Env and Org Forms not showing to Attach to S3 Dataset Entity Anymore
- This is from earlier PR when changing entityType to S3-Dataset: At createAttachedMetadataForm API in RenderedMetadataForm UI View we use entityType Dataset not S3-Dataset
- The source is from DatasetView - Line: <MetadataAttachment entityType="Dataset" entityUri={params.uri} />

Just need to change to S3-Dataset

[noah-paige]

some minor comments

Is access restrictions to be reconsidered later - just curious to hear thoughts here, I think outside scope of this PR for now

[SofiaSazonova]

All done

[noah-paige]

Minor Comment on Theme(s)

One Bug Found (described below)

Bug when updating an already attached metadata form with a boolean value...

• If there already exists an attached MF with a boolean value and I have a new MF Form version still with the same boolean value

  • When I click edit - the fields get carried over to new version
  • These field values are from AttachedMetadataForm.fields property returned from listAttachedMetadataForms API and the values are returned as strings
  • Meaning a boolean value is returned as 'false'

• If I keep the boolean value as is and try to save this new version of the attached form I get an error

(builtins.TypeError) Not a boolean value: 'false' [SQL: INSERT INTO boolean_attached_metadata_form_field ("attachedFormUri", "fieldUri", value) VALUES (%(attachedFormUri)s, %(fieldUri)s, %(value)s)] [parameters: [{'value': 'false', 'attachedFormUri': 'XXX', 'fieldUri': 'XXXX'}]]

- Believe something is going on with boolean returned as string ++`JSON.stringify(field.value)` used before running `createAttachedMetadataForm`
- Looking at Lambda event the value comes in as `"\"false\""` which then gets loaded as `'false'` after json.loads(xxx) and then this string throws the error because not bool type

Ultimately, I get left with an error and 2 attached metadata forms of 2 different versions because createAttachedMetadataForm is also not cleaning up the pre-existing one due the error

[SofiaSazonova]

bugs with attachement and values resolved
themes & colors fixed