Introduce sharing State Machines #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@noah-paige @degoldner
Found issues:
|
|
After fixing:
Today I will work on:
|
|
@degoldner I refractored the sharing api tests. Thank you for pointing it out, I like this last version better :) |
noah-paige
approved these changes
Jan 31, 2023
There was a problem hiding this comment.
I have gone through testing all the new and existing sharing functionality for folders and tables - all seems to be working well and really enjoy the new design and sharing process leveraging the Share SMs
I opened 2 more general issues that I found that are not specific to sharing ( #288 and #287 ) otherwise this PR lgtm
Merged
dlpzx
added a commit
that referenced
this pull request
Feb 3, 2023
- Feature - Refactoring - Embed sharing actions into code defined State machines - Redesign the sharing workflow to keep track of revoke of access - Adjust and simplify sharing managers and tasks - separation of approval and revoke process - Revoke items in batch - Added info in share statistics in inbox and outbox - Added testing for S3 and LakeFormation share managers and for sharing APIs (Check out the conversation in the below issue for more details) - #255 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: Dennis Goldner <[email protected]>
dlpzx
added a commit
that referenced
this pull request
Feb 7, 2023
### Feature or Bugfix - Bugfix ### Detail - Issue on revoking principals in sharing ### Relates - #267 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: Dennis Goldner <[email protected]>
dlpzx
added a commit
that referenced
this pull request
Feb 9, 2023
### Feature or Bugfix - v.1.4.0 Features ### Detail - #267 - Sharing State Machines - #289 - Visibility of shared access points and databases - #259 - Pipeline filter to search them By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: Noah Paige <[email protected]> Co-authored-by: Dennis Goldner <[email protected]>
noah-paige
pushed a commit
to noah-paige/aws-dataall
that referenced
this pull request
Mar 2, 2023
- Feature - Refactoring - Embed sharing actions into code defined State machines - Redesign the sharing workflow to keep track of revoke of access - Adjust and simplify sharing managers and tasks - separation of approval and revoke process - Revoke items in batch - Added info in share statistics in inbox and outbox - Added testing for S3 and LakeFormation share managers and for sharing APIs (Check out the conversation in the below issue for more details) - data-dot-all#255 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: Dennis Goldner <[email protected]>
dlpzx
added a commit
that referenced
this pull request
Mar 6, 2023
### Feature or Bugfix - v.1.4.0 Features ### Detail - #267 - Sharing State Machines - #289 - Visibility of shared access points and databases - #259 - Pipeline filter to search them By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: Noah Paige <[email protected]> Co-authored-by: Dennis Goldner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Detail
(Check out the conversation in the below issue for more details)
Relates
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.