Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added kms:createGrant to environmentGroups (no admin groups) #335

Conversation

dlpzx
Copy link
Contributor

@dlpzx dlpzx commented Feb 27, 2023

Feature or Bugfix

  • Bugfix

Detail

  • Added kms:createGrant permission for all environment IAM roles.

Comment: we have noticed that for the environment admin team IAM role the following is added whenever they create a dataset (backend/dataall/cdkproxy/stacks/policies/data_policy.py)

iam.PolicyStatement(
                    actions=['athena:*', 'lakeformation:*', 'glue:*', 'kms:*'],
                    resources=['*'],
                ),

Maybe it is a good moment to re-review the IAM policies of:

  • pivotRole
  • environmentGroup IAM roles (Admin and non-admin)
  • dataset IAM role
    But this can be handled in a different PR

Relates

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@chamcca
Copy link
Contributor

chamcca commented Feb 28, 2023

let's create a ticket to review the IAM policies of:

  • pivotRole
  • environmentGroup IAM roles (Admin and non-admin)
  • dataset IAM role

@dlpzx dlpzx merged commit 4569efd into main Feb 28, 2023
@dlpzx dlpzx deleted the 326-sagemaker-ml-studio-the-jupyterserver-app-default-encountered-a-problem-and-was-stopped-is-not-authorized-to-perform-kmscreategrant branch March 1, 2023 07:49
dlpzx added a commit that referenced this pull request Mar 6, 2023
### Feature or Bugfix
- Bugfix

### Detail
- Added kms:createGrant permission for all environment IAM roles. 

### Relates
- #326 

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants