Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend Modularization: Glossaries #640

Conversation

maryamkhidir
Copy link
Contributor

Feature or Bugfix

  • Refactoring

Detail

  • Modularized Glossaries folder into components, views and services
  • Refactored relative imports used in the module to use absolute paths
  • Removed unused scripts
  • Updated routes to reflect new file paths

Relates

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@maryamkhidir maryamkhidir added the type: modularization Code refactoring project label Aug 8, 2023
@maryamkhidir maryamkhidir added this to the v2.0.0 milestone Aug 8, 2023
@maryamkhidir maryamkhidir requested a review from dlpzx August 11, 2023 11:07
Copy link
Contributor

@itsmo-amzn itsmo-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maryamkhidir maryamkhidir merged commit 6b691c1 into data-dot-all:modularization/frontend Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: modularization Code refactoring project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants