-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frontend Modularization: Environments #642
Merged
itsmo-amzn
merged 14 commits into
data-dot-all:modularization/frontend
from
itsmo-amzn:itsmo-amzn/frontend-mod/environments
Aug 14, 2023
Merged
Frontend Modularization: Environments #642
itsmo-amzn
merged 14 commits into
data-dot-all:modularization/frontend
from
itsmo-amzn:itsmo-amzn/frontend-mod/environments
Aug 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsmo-amzn
force-pushed
the
itsmo-amzn/frontend-mod/environments
branch
from
August 10, 2023 08:50
b195fa7
to
caa9470
Compare
nikpodsh
reviewed
Aug 10, 2023
nikpodsh
reviewed
Aug 10, 2023
nikpodsh
approved these changes
Aug 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having deleted the dead code from the backend, the PR started shining in a new light! 😄
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Detail
Relates
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.