Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend Modularization: Environments #642

Conversation

itsmo-amzn
Copy link
Contributor

Feature or Bugfix

  • Refactoring

Detail

  • Move Environments views into Environments module
  • Move services that were only used by Environments into Environments module
  • Move Environments components into Environments module

Relates

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@itsmo-amzn itsmo-amzn marked this pull request as ready for review August 9, 2023 08:09
@itsmo-amzn itsmo-amzn added the type: modularization Code refactoring project label Aug 9, 2023
@itsmo-amzn itsmo-amzn force-pushed the itsmo-amzn/frontend-mod/environments branch from b195fa7 to caa9470 Compare August 10, 2023 08:50
@itsmo-amzn itsmo-amzn requested a review from dlpzx August 10, 2023 10:12
Copy link
Contributor

@nikpodsh nikpodsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having deleted the dead code from the backend, the PR started shining in a new light! 😄
LGTM!

@itsmo-amzn itsmo-amzn merged commit 405b9ff into data-dot-all:modularization/frontend Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: modularization Code refactoring project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants