Refine CDK Custom Exec Policy - Linking Envs #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlpzx
reviewed
Aug 10, 2023
| @@ -48,14 +45,14 @@ Resources: | |||
| Effect: Allow | |||
| Action: 'athena:CreateWorkGroup' | |||
| Resource: | |||
| - !Sub 'arn:aws:athena:*:${AWS::AccountId}:workgroup/*' | |||
| - !Sub 'arn:${AWS::Partition}:athena:*:${AWS::AccountId}:workgroup/*' | |||
dlpzx
reviewed
Aug 10, 2023
| @@ -232,7 +229,7 @@ Resources: | |||
| Action: | |||
| - 's3:*' | |||
| Resource: | |||
| - !Sub 'arn:aws:s3:::cdktoolkit-stagingbucket-*' | |||
| - !Sub 'arn:${AWS::Partition}:s3:::cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}*' | |||
There was a problem hiding this comment.
Wow, how did we miss this? Thanks!
dlpzx
approved these changes
Aug 10, 2023
|
Looks good. I think we can merge to |
|
@dlpzx, all frontend modularization PRs are targeting to the other branch ( |
nikpodsh
added a commit
that referenced
this pull request
Aug 16, 2023
Merge latest changes from main into modularization-main It includes changes from #626, #630, #648, #649, and #651 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dlpzx <[email protected]> Co-authored-by: wolanlu <[email protected]> Co-authored-by: Amr Saber <[email protected]> Co-authored-by: Noah Paige <[email protected]> Co-authored-by: kukushking <[email protected]> Co-authored-by: Dariusz Osiennik <[email protected]> Co-authored-by: Dennis Goldner <[email protected]> Co-authored-by: Abdulrahman Kaitoua <[email protected]> Co-authored-by: akaitoua-sa <[email protected]> Co-authored-by: Gezim Musliaj <[email protected]> Co-authored-by: Rick Bernotas <[email protected]> Co-authored-by: David Mutune Kimengu <[email protected]> Co-authored-by: chamcca <[email protected]> Co-authored-by: Dhruba <[email protected]> Co-authored-by: dbalintx <[email protected]> Co-authored-by: Srinivas Reddy <[email protected]> Co-authored-by: mourya-33 <[email protected]> Co-authored-by: Noah Paige <[email protected]> Co-authored-by: dlpzx <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Detail
Relates
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.