Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cdk exec policy for bootstraping linked accounts (#763) #768

Merged
merged 4 commits into from
Sep 18, 2023

Conversation

noah-paige
Copy link
Contributor

@noah-paige noah-paige commented Sep 15, 2023

Feature or Bugfix

  • Enhancement

Detail

Remove overly permissive permissions in the optional cdk execution bootstrapping policy

Security

Please answer the questions below briefly where applicable, or write N/A. Based on
OWASP 10.

  • Does this PR introduce or modify any input fields or queries - this includes
    fetching data from storage outside the application (e.g. a database, an S3 bucket)?
    • Is the input sanitized?
    • What precautions are you taking before deserializing the data you consume?
    • Is injection prevented by parametrizing queries?
    • Have you ensured no eval or similar functions are used?

NA

  • Does this PR introduce any functionality or component that requires authorization?
    • How have you ensured it respects the existing AuthN/AuthZ mechanisms?
    • Are you logging failed auth attempts?

NA

  • Are you using or adding any cryptographic features?
    • Do you use a standard proven implementations?
    • Are the used keys controlled by the customer? Where are they stored?

NA

  • Are you introducing any new policies/roles/users?
    • Have you used the least-privilege principle? How?

Adding additional restrictions to permission set for cdk execution bootstrapping policy when bootstrapping / linking environments

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

mourya-33 and others added 3 commits September 15, 2023 08:57
### Feature or Bugfix

- Bugfix

### Detail
Remove overly permissive permissions in the policy


By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

---------

Co-authored-by: dlpzx <[email protected]>
@noah-paige noah-paige marked this pull request as ready for review September 15, 2023 12:58
@noah-paige noah-paige assigned noah-paige and unassigned noah-paige Sep 15, 2023
@noah-paige
Copy link
Contributor Author

noah-paige commented Sep 15, 2023

Tested in AWS Deployment For:

  • Create, Update, Delete Linked Environment
    • Same Region as Deployment Acct
    • All Features Enabled + No Default VPC
  • Create, Update, Delete Linked Environment
    • Cross Region as Deployment Acct
    • All Features Enabled + Default VPC
  • Create, Delete Dataset
  • Create, Delete Notebook
  • Create, Delete MLStudio User
  • Create, Delete CDK Pipeline
  • Create, Delete Trunk-Based Pipeline
  • Create, Delete Gitflow Pipeline

@noah-paige noah-paige requested a review from dlpzx September 15, 2023 13:35
@noah-paige noah-paige merged commit 9885da2 into main Sep 18, 2023
@dlpzx dlpzx deleted the restrict-cdk-exec-policy branch November 8, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants