Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create frontend config role regardless of custom auth or not in backend #913

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

noah-paige
Copy link
Contributor

…nd stack

Feature or Bugfix

  • Bugfix

Detail

  • Config Role used to read SSM parameters in deployment account assumed by tooling account needs to be created in the BackendStack so it can be used in the pre CodeBuild commands of the ALBFront Stack
  • Applies for VPC Facing Deployments

Relates

Security

Please answer the questions below briefly where applicable, or write N/A. Based on
OWASP 10.

  • Does this PR introduce or modify any input fields or queries - this includes
    fetching data from storage outside the application (e.g. a database, an S3 bucket)?
    • Is the input sanitized?
    • What precautions are you taking before deserializing the data you consume?
    • Is injection prevented by parametrizing queries?
    • Have you ensured no eval or similar functions are used?
  • Does this PR introduce any functionality or component that requires authorization?
    • How have you ensured it respects the existing AuthN/AuthZ mechanisms?
    • Are you logging failed auth attempts?
  • Are you using or adding any cryptographic features?
    • Do you use a standard proven implementations?
    • Are the used keys controlled by the customer? Where are they stored?
  • Are you introducing any new policies/roles/users?
    • Have you used the least-privilege principle? How?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@noah-paige noah-paige marked this pull request as ready for review December 12, 2023 21:26
@dlpzx
Copy link
Contributor

dlpzx commented Dec 13, 2023

Yes, I encountered this error while testing. I have reviewed the PR and it makes much more sense to have a dedicated role for the frontend deployment. I am not sure if I would place it in the backend stack, but I don't see a better place at the moment. Maybe in the future we can think of a frontend stack that groups all albfront, cloudfront... resources but for the moment I think this PR serves its purpose.

I will do some testing in AWS and approved afterwards.

@dlpzx
Copy link
Contributor

dlpzx commented Dec 13, 2023

Tested in AWS! approving

@dlpzx dlpzx merged commit 2652202 into main Dec 13, 2023
9 checks passed
@dlpzx dlpzx deleted the fix/custom-auth-vpc-facing branch January 10, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants