M1466 alternative toggle #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmnoo
commented
Feb 17, 2021
|
|
||
| const OfflineToggle = () => { | ||
| const [checked, setChecked] = useState(false) |
There was a problem hiding this comment.
Im thinking controlled input state can come later and will probably be in a parent component who owns offline status, or some custom hook instance.
There was a problem hiding this comment.
I agree, I'm thinking to store in a global state with context or redux.
mmnoo
force-pushed
the
M1466-alternativeToggle
branch
from
358a735 to
93a8b3b
Compare
mmnoo
commented
Feb 17, 2021
| /** | ||
| * Describe your component | ||
| */ | ||
| const ToggleCss = raw('react-toggle/style.css') |
There was a problem hiding this comment.
hack to get css without having it added globally. facebook/create-react-app#3722 (comment)
mmnoo
commented
Feb 17, 2021
| const OfflineToggle = () => { | ||
| const [checked, setChecked] = useState(false) | ||
| const ToggleWrapper = styled.div` | ||
| ${ToggleCss} |
There was a problem hiding this comment.
dump the expected third party css in a styled component wrapper and override it with library classnames.
|
@tienhoah Im thinking I like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposing
react-toggleinstead ofreact-switchfor code maintainability (styled via css/styled components, not inline, or in return statement/jsx)