refactor: Use CrudMgr to impl FileFormatMgr (#14999)

- Fix: #14934

src/meta/app/src/principal/mod.rs

@@ -26,6 +26,7 @@ mod role_ident;
 mod role_info;
 mod user_auth;
 mod user_defined_file_format;
+pub mod user_defined_file_format_ident;
 mod user_defined_function;
 mod user_grant;
 mod user_identity;

src/meta/app/src/principal/user_defined_file_format_ident.rs

@@ -0,0 +1,83 @@
+// Copyright 2021 Datafuse Labs
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+use crate::tenant_key::TIdent;
+
+/// Defines the meta-service key for user defined file format.
+pub type UserDefinedFileFormatIdent = TIdent<Resource>;
+
+pub use kvapi_impl::Resource;
+
+mod kvapi_impl {
+
+    use databend_common_exception::ErrorCode;
+    use databend_common_meta_kvapi::kvapi;
+
+    use crate::principal::UserDefinedFileFormat;
+    use crate::tenant_key::TenantResource;
+    use crate::tenant_key_errors::ExistError;
+    use crate::tenant_key_errors::UnknownError;
+
+    pub struct Resource;
+    impl TenantResource for Resource {
+        const PREFIX: &'static str = "__fd_file_formats";
+        type ValueType = UserDefinedFileFormat;
+    }
+
+    impl kvapi::Value for UserDefinedFileFormat {
+        fn dependency_keys(&self) -> impl IntoIterator<Item = String> {
+            []
+        }
+    }
+
+    impl kvapi::ValueWithName for UserDefinedFileFormat {
+        fn name(&self) -> &str {
+            &self.name
+        }
+    }
+
+    impl From<ExistError<Resource>> for ErrorCode {
+        fn from(err: ExistError<Resource>) -> Self {
+            ErrorCode::FileFormatAlreadyExists(err.to_string())
+        }
+    }
+
+    impl From<UnknownError<Resource>> for ErrorCode {
+        fn from(err: UnknownError<Resource>) -> Self {
+            ErrorCode::UnknownFileFormat(err.to_string())
+        }
+    }
+}
+
+#[cfg(test)]
+mod tests {
+    use databend_common_meta_kvapi::kvapi::Key;
+
+    use crate::principal::user_defined_file_format_ident::UserDefinedFileFormatIdent;
+    use crate::tenant::Tenant;
+
+    #[test]
+    fn test_file_format_ident() {
+        let tenant = Tenant::new("test".to_string());
+        let ident = UserDefinedFileFormatIdent::new(tenant, "test1");
+
+        let key = ident.to_string_key();
+        assert_eq!(key, "__fd_file_formats/test/test1");
+
+        assert_eq!(
+            ident,
+            UserDefinedFileFormatIdent::from_str_key(&key).unwrap()
+        );
+    }
+}

src/query/management/src/file_format/mod.rs → src/query/management/src/file_format.rs

@@ -12,8 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-mod file_format_api;
-mod file_format_mgr;
+use databend_common_meta_api::crud::CrudMgr;
+use databend_common_meta_app::principal::user_defined_file_format_ident;
 
-pub use file_format_api::FileFormatApi;
-pub use file_format_mgr::FileFormatMgr;
+pub type FileFormatMgr = CrudMgr<user_defined_file_format_ident::Resource>;

src/query/management/src/lib.rs

@@ -33,7 +33,6 @@ pub use cluster::ClusterApi;
 pub use cluster::ClusterMgr;
 pub use connection::ConnectionApi;
 pub use connection::ConnectionMgr;
-pub use file_format::FileFormatApi;
 pub use file_format::FileFormatMgr;
 pub use network_policy::NetworkPolicyMgr;
 pub use password_policy::PasswordPolicyMgr;

src/query/service/src/interpreters/interpreter_file_format_create.rs

@@ -62,11 +62,7 @@ impl Interpreter for CreateFileFormatInterpreter {
 
         let tenant = self.ctx.get_tenant();
         let _create_file_format = user_mgr
-            .add_file_format(
-                tenant.as_str(),
-                user_defined_file_format,
-                &plan.create_option,
-            )
+            .add_file_format(&tenant, user_defined_file_format, &plan.create_option)
             .await?;
 
         Ok(PipelineBuildResult::create())

src/query/service/src/interpreters/interpreter_file_format_drop.rs

@@ -56,7 +56,7 @@ impl Interpreter for DropFileFormatInterpreter {
         let user_mgr = UserApiProvider::instance();
 
         user_mgr
-            .drop_file_format(tenant.as_str(), &plan.name, plan.if_exists)
+            .drop_file_format(&tenant, &plan.name, plan.if_exists)
             .await?;
 
         Ok(PipelineBuildResult::create())

src/query/service/src/interpreters/interpreter_file_format_show.rs

@@ -54,7 +54,7 @@ impl Interpreter for ShowFileFormatsInterpreter {
 
         let user_mgr = UserApiProvider::instance();
         let tenant = self.ctx.get_tenant();
-        let mut formats = user_mgr.get_file_formats(tenant.as_str()).await?;
+        let mut formats = user_mgr.get_file_formats(&tenant).await?;
 
         formats.sort_by(|a, b| a.name.cmp(&b.name));
 

src/query/service/src/sessions/query_ctx.rs

@@ -752,7 +752,7 @@ impl TableContext for QueryContext {
                 let user_mgr = UserApiProvider::instance();
                 let tenant = self.get_tenant();
                 Ok(user_mgr
-                    .get_file_format(tenant.as_str(), name)
+                    .get_file_format(&tenant, name)
                     .await?
                     .file_format_params)
             }