Skip to content

Commit

Permalink
Merge pull request #5429 from b41sh/fix-array-nullable-write
Browse files Browse the repository at this point in the history
fix(data type): update arrow2 to fix array nullable write
  • Loading branch information
BohuTANG authored May 17, 2022
2 parents 7bf61aa + 304bdbd commit 93bf755
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 3 deletions.
4 changes: 2 additions & 2 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion common/arrow/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ simd = ["arrow/simd"]
arrow = { package = "arrow2", git = "https://github.com/datafuse-extras/arrow2", default-features = false, features = [
"io_parquet",
"io_parquet_compression",
], rev = "2d70fbf46fd37f4ef532945c588be69a71998e44" }
], rev = "826a2b8" }

# Crates.io dependencies
arrow-format = { version = "0.4.0", features = ["flight-data", "flight-service", "ipc"] }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,3 +81,10 @@ aa bb
cc dd
NULL NULL
ee ff
==Array(Int64) Nullable==
1 [1, 2, 3, 4]
2 [5, 6, 7, 8]
3 NULL
1 2
5 6
NULL NULL
9 changes: 9 additions & 0 deletions tests/suites/0_stateless/03_dml/03_0023_insert_into_array.sql
Original file line number Diff line number Diff line change
Expand Up @@ -139,4 +139,13 @@ INSERT INTO t15 (id, arr) VALUES(1, ['aa', 'bb']), (2, ['cc', 'dd']), (3, null),
select * from t15;
select arr[0], arr[1] from t15;

select '==Array(Int64) Nullable==';

CREATE TABLE IF NOT EXISTS t16(id Int, arr Array(Int64) Null) Engine = fuse;

INSERT INTO t16 (id, arr) VALUES(1, [1,2,3,4]), (2, [5,6,7,8]), (3, null);

select * from t16;
select arr[0], arr[1] from t16;

DROP DATABASE db1;

0 comments on commit 93bf755

Please sign in to comment.