Skip to content

Commit

Permalink
add DataType::Data32 for try_into_data_array
Browse files Browse the repository at this point in the history
  • Loading branch information
dantengsky committed Oct 21, 2021
1 parent 351fc51 commit b8b128e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
3 changes: 3 additions & 0 deletions common/datavalues/src/data_value_ops.rs
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,9 @@ impl DataValue {
DataType::Date16 => {
try_build_array! {PrimitiveArrayBuilder, u16, UInt16, values}
}
DataType::Date32 => {
try_build_array! {PrimitiveArrayBuilder, i32, Int32, values}
}
DataType::DateTime32(_) => {
try_build_array! {PrimitiveArrayBuilder, u32, UInt32, values}
}
Expand Down
5 changes: 1 addition & 4 deletions common/datavalues/src/macros.rs
Original file line number Diff line number Diff line change
Expand Up @@ -186,10 +186,7 @@ macro_rules! try_build_array {
match value {
DataValue::$SCALAR_TY(Some(v)) => builder.append_value(*v),
DataValue::$SCALAR_TY(None) => builder.append_null(),
dv => {
eprintln!("DV is {:?}", dv);
unreachable!()
}
_ => unreachable!(),
}
}
Ok(builder.finish().into_series())
Expand Down

0 comments on commit b8b128e

Please sign in to comment.