Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(query): support desc table with decimal type and support order by decmail type col #10113

Merged
merged 4 commits into from
Feb 23, 2023

Conversation

TCeason
Copy link
Collaborator

@TCeason TCeason commented Feb 18, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

support desc table with decimal type and support order by decmail type col

Closes #10005

@vercel
Copy link

vercel bot commented Feb 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
databend ⬜️ Ignored (Inspect) Feb 23, 2023 at 9:49AM (UTC)

@TCeason TCeason requested a review from sundy-li February 18, 2023 02:00
@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Feb 18, 2023
@BohuTANG
Copy link
Member

make lint:

error: unused import: `crate::with_decimal_type`
  --> src/query/expression/src/types.rs:67:5
   |
67 | use crate::with_decimal_type;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `-D unused-imports` implied by `-D warnings`

@sundy-li
Copy link
Member

@TCeason So arrow2 does not support Decimal256, you can convert Decimal256 to FixedByteArray.

@sundy-li
Copy link
Member

@TCeason
Copy link
Collaborator Author

TCeason commented Feb 23, 2023

Now we create a new issue #10180 to support arrow2 decimal256. So this pr can be reviewed.

@BohuTANG BohuTANG merged commit cabbc7b into databendlabs:main Feb 23, 2023
@BohuTANG BohuTANG mentioned this pull request Feb 24, 2023
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add min/max aggregate function on Decimal, support order by Decimal datatypes @TCeason
3 participants