Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(query): add compare op for decimal types #10214

Merged
merged 4 commits into from
Feb 25, 2023
Merged

feat(query): add compare op for decimal types #10214

merged 4 commits into from
Feb 25, 2023

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Feb 25, 2023 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR

@sundy-li sundy-li requested a review from youngsofun February 25, 2023 02:50
@vercel
Copy link

vercel bot commented Feb 25, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
databend ⬜️ Ignored (Inspect) Feb 25, 2023 at 3:14AM (UTC)

@sundy-li sundy-li requested a review from TCeason February 25, 2023 02:50
@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Feb 25, 2023
@sundy-li sundy-li mentioned this pull request Feb 25, 2023
Closed
17 tasks
TCeason
TCeason approved these changes Feb 25, 2023
View reviewed changes
Copy link
Collaborator

@TCeason TCeason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, now we can compare the same decimal type with diff size.

@BohuTANG BohuTANG added the ci-benchmark Benchmark: run all test label Feb 25, 2023
@github-actions
Copy link
Contributor

platform
Benchmark Results: https://repo.databend.rs/benchmark/clickbench/pr/10214/4268130125.html

@BohuTANG BohuTANG merged commit 2034837 into databendlabs:main Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BohuTANG BohuTANG BohuTANG left review comments

@TCeason TCeason TCeason approved these changes

@youngsofun youngsofun Awaiting requested review from youngsofun

Assignees
No one assigned
Labels
ci-benchmark Benchmark: run all test pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sundy-li @BohuTANG @TCeason