Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(query): Remove the v2 suffix of structs #10291

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

TCeason
Copy link
Collaborator

@TCeason TCeason commented Mar 2, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Now we has already migrate to planner v2, modify some struct with V2 suffix and rename some file with _v2 suffix.

Closes #issue

@vercel
Copy link

vercel bot commented Mar 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
databend ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 2, 2023 at 2:42AM (UTC)

@TCeason TCeason requested review from Xuanwo, sundy-li and BohuTANG March 2, 2023 01:03
@mergify mergify bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Mar 2, 2023
@BohuTANG
Copy link
Member

BohuTANG commented Mar 2, 2023

make lint

@TCeason TCeason force-pushed the refactor_v2 branch 2 times, most recently from 3bffc76 to 0b63534 Compare March 2, 2023 02:39
@TCeason
Copy link
Collaborator Author

TCeason commented Mar 2, 2023

typo err:

error: platfom should be platform
--> ./docs/doc/10-deploy/01-installing-databend.md:10:91
|
10 | - Manual download: You can download the installation package for your platfom directly from the Databend website.
| ^^^^^^^
|

fixed in this pr.

@Xuanwo Xuanwo changed the title chore(query): rafactor xx_v2 refactor(query): Remove the v2 suffix of structs Mar 2, 2023
@mergify mergify bot added the pr-refactor this PR changes the code base without new features or bugfix label Mar 2, 2023
@BohuTANG
Copy link
Member

BohuTANG commented Mar 2, 2023

Great.

@BohuTANG BohuTANG merged commit 6b1efac into databendlabs:main Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles. pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants