Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(query): support decimal256 select insert #10297

Merged
merged 2 commits into from
Mar 3, 2023
Merged

feat(query): support decimal256 select insert #10297

merged 2 commits into from
Mar 3, 2023

Conversation

TCeason
Copy link
Collaborator

@TCeason TCeason commented Mar 2, 2023 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

support decimal256 select insert

Closes #10180

@vercel
Copy link

vercel bot commented Mar 2, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
databend ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 3, 2023 at 10:34AM (UTC)

@mergify mergify bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Mar 2, 2023
@TCeason TCeason force-pushed the support_decimal256 branch from 28a85a6 to 86b85b9 Compare March 2, 2023 02:47
@TCeason TCeason requested review from youngsofun and sundy-li March 2, 2023 02:56
@TCeason TCeason force-pushed the support_decimal256 branch from 86b85b9 to 546229a Compare March 2, 2023 05:33
@TCeason
Copy link
Collaborator Author

TCeason commented Mar 2, 2023

The failed case is not relevant to this pr @sundy-li

@ariesdevil
Copy link
Contributor

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Mar 2, 2023

update

✅ Branch has been successfully updated

Xuanwo
Xuanwo reviewed Mar 2, 2023
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
@TCeason TCeason marked this pull request as draft March 2, 2023 11:34
@TCeason TCeason force-pushed the support_decimal256 branch from bd106ec to b750be2 Compare March 3, 2023 09:46
@TCeason TCeason changed the title chore(query): test arrow2 decimal256 feat(query): support decimal256 Mar 3, 2023
@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Mar 3, 2023
@TCeason TCeason changed the title feat(query): support decimal256 feat(query): support decimal256 select insert Mar 3, 2023
@TCeason TCeason marked this pull request as ready for review March 3, 2023 10:32
@mergify mergify bot merged commit 2404959 into databendlabs:main Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BohuTANG BohuTANG BohuTANG left review comments

@sundy-li sundy-li Awaiting requested review from sundy-li

@youngsofun youngsofun Awaiting requested review from youngsofun

@Xuanwo Xuanwo Awaiting requested review from Xuanwo

Assignees
No one assigned
Labels
pr-chore this PR only has small changes that no need to record, like coding styles. pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Now decimal128 is already ok. So i think we can create a new issue to fix decimal256.
6 participants
@TCeason @ariesdevil @BohuTANG @sundy-li @Xuanwo @youngsofun