Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deps] switch to comfy-table from prettytable #1126

Merged
merged 1 commit into from
Jul 21, 2021

Conversation

PsiACE
Copy link
Member

@PsiACE PsiACE commented Jul 21, 2021

Signed-off-by: Chojan Shang [email protected]

I hereby agree to the terms of the CLA available at: https://datafuse.rs/policies/cla/

Summary

Switch to comfy-table from prettytable. In addition, comfy-table is still actively maintained.

Changelog

  • Improvement

Related Issues

Fixes #1095

Test Plan

Unit Tests

Stateless Tests

@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@databend-bot
Copy link
Member

Hello @PsiACE, 🎉 Thank you for opening the pull request! 🎉
Your pull request state is not in Draft, please add Reviewers or Re-request review again!
FuseQuery: @BohuTANG @sundy-li @zhang2014
FuseStore: @drmingdrmer @dantengsky
Or visit datafuse roadmap for some clues.

@PsiACE PsiACE requested review from sundy-li and BohuTANG July 21, 2021 03:02
@@ -18,4 +18,4 @@ common-infallible = {path = "../infallible"}

# Crates.io dependencies
ahash = "0.7.4"
prettytable-rs = { version = "0.8.0"}
comfy-table = "4.0.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@BohuTANG BohuTANG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @PsiACE

@codecov-commenter
Copy link

Codecov Report

Merging #1126 (236e282) into master (8548b8f) will increase coverage by 16%.
The diff coverage is 42%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1126      +/-   ##
=========================================
+ Coverage      52%     68%     +16%     
=========================================
  Files         108     434     +326     
  Lines        7306   24692   +17386     
=========================================
+ Hits         3847   17006   +13159     
- Misses       3459    7686    +4227     
Impacted Files Coverage Δ
common/datavalues/src/series/series_debug.rs 0% <0%> (ø)
common/datablocks/src/data_block_debug.rs 100% <100%> (ø)
common/metatypes/src/errors.rs 42% <0%> (-58%) ⬇️
common/streams/src/stream.rs 80% <0%> (-20%) ⬇️
common/datavalues/src/macros.rs 36% <0%> (-19%) ⬇️
common/infallible/src/rwlock.rs 82% <0%> (-18%) ⬇️
common/metatypes/src/match_seq.rs 95% <0%> (-3%) ⬇️
common/datavalues/src/arrays/builders/builder.rs 39% <0%> (-1%) ⬇️
common/datavalues/src/data_type.rs 52% <0%> (-1%) ⬇️
common/infallible/src/mutex.rs 100% <0%> (ø)
... and 346 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8548b8f...236e282. Read the comment docs.

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot databend-bot merged commit 3948c1e into databendlabs:master Jul 21, 2021
@PsiACE PsiACE deleted the comfy-table branch July 21, 2021 03:19
@PsiACE PsiACE mentioned this pull request Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RUSTSEC-2018-0015: term is looking for a new maintainer
4 participants