feat: auto optimize table during execution of replace into statement
#12100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
github-actions
bot
added
the
pr-feature
zhyass
reviewed
Jul 17, 2023
src/query/service/src/interpreters/interpreter_table_optimize.rs
Outdated
Show resolved
Hide resolved
zhyass
approved these changes
Jul 17, 2023
dantengsky
commented
Jul 17, 2023
src/query/service/src/interpreters/interpreter_table_optimize.rs
Outdated
Show resolved
Hide resolved
SkyFan2002
added a commit
to SkyFan2002/databend
that referenced
this pull request
Jul 26, 2023
BohuTANG
pushed a commit
that referenced
this pull request
Aug 10, 2023
* refactor copy into * fix panic * fix * fix * fix * make lint * fix logic error * replace into values * fix * fix * fix render result * fix schema cast * temp * respect #12147 * respect #12100 * make lint * respect #12130 * fix merge * add exchange * fix conflict * fix schema cast * fix conlfict * fix * fix copy plan * clear log * fix copy * fix copy * run ci * fix purge * make lint * add exchange * disable dist for value source * adjust exchange * remove top exchange * adjust replace into * reshuffle * fix * fix reshuffle * move segment_partition_num * resolve conflicts * add need insert flag * unbranched_replace_into_processor * merge only pipeline * fix segment index * fix conflict * remove log * fix empty table * fix stateful test * fix stateful test * modify test * fix typo * fix random source * add setting * remove empty file * remove dead code * add default setting * Update src/query/service/src/interpreters/interpreter_replace.rs Co-authored-by: dantengsky <[email protected]> * Update src/query/sql/src/executor/physical_plan_display.rs Co-authored-by: dantengsky <[email protected]> * Update src/query/storages/fuse/src/operations/replace_into/processors/processor_unbranched_replace_into.rs Co-authored-by: dantengsky <[email protected]> * Update src/query/sql/src/executor/physical_plan.rs Co-authored-by: dantengsky <[email protected]> * Update src/query/sql/src/executor/physical_plan_display.rs Co-authored-by: dantengsky <[email protected]> * rename struct * default 0 * regen golden file * set enable_distributed_replace_into = 1 in slt * make lint --------- Co-authored-by: dantengsky <[email protected]> Co-authored-by: JackTan25 <[email protected]>
andylokandy
pushed a commit
to andylokandy/databend
that referenced
this pull request
Nov 27, 2023
databendlabs#12100) * chain replace into with optimize table * tweak sqllogic test case * fix typo * Update src/query/service/src/interpreters/interpreter_table_optimize.rs
andylokandy
pushed a commit
to andylokandy/databend
that referenced
this pull request
Nov 27, 2023
…2119) * refactor copy into * fix panic * fix * fix * fix * make lint * fix logic error * replace into values * fix * fix * fix render result * fix schema cast * temp * respect databendlabs#12147 * respect databendlabs#12100 * make lint * respect databendlabs#12130 * fix merge * add exchange * fix conflict * fix schema cast * fix conlfict * fix * fix copy plan * clear log * fix copy * fix copy * run ci * fix purge * make lint * add exchange * disable dist for value source * adjust exchange * remove top exchange * adjust replace into * reshuffle * fix * fix reshuffle * move segment_partition_num * resolve conflicts * add need insert flag * unbranched_replace_into_processor * merge only pipeline * fix segment index * fix conflict * remove log * fix empty table * fix stateful test * fix stateful test * modify test * fix typo * fix random source * add setting * remove empty file * remove dead code * add default setting * Update src/query/service/src/interpreters/interpreter_replace.rs Co-authored-by: dantengsky <[email protected]> * Update src/query/sql/src/executor/physical_plan_display.rs Co-authored-by: dantengsky <[email protected]> * Update src/query/storages/fuse/src/operations/replace_into/processors/processor_unbranched_replace_into.rs Co-authored-by: dantengsky <[email protected]> * Update src/query/sql/src/executor/physical_plan.rs Co-authored-by: dantengsky <[email protected]> * Update src/query/sql/src/executor/physical_plan_display.rs Co-authored-by: dantengsky <[email protected]> * rename struct * default 0 * regen golden file * set enable_distributed_replace_into = 1 in slt * make lint --------- Co-authored-by: dantengsky <[email protected]> Co-authored-by: JackTan25 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
this PR is a squashed version of #12059
during the execution of
replace-into, the table will be autooptimize compact, and that implies if the table being replaced-into has a cluster key, it will be automatically reclustered as well (see PR #11850)besides CI, this PR has been tested by
https://github.com/dantengsky/rr
using both
single node deployment, local fs; 65000 iterations,
medium size WH; 25000 iterations
for both settings, no error was detected.