Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: target only expr push down #13082

Closed
wants to merge 1 commit into from
Closed

feat: target only expr push down #13082

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/query/sql/src/planner/binder/merge_into.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,6 @@ impl Binder {
self.bind_single_table(bind_context, &source_data).await?;

// add all left source columns for read
// todo: (JackTan25) do column prune after finish "split expr for target and source"
let mut columns_set = left_context.column_set();

let update_columns_star = if self.has_star_clause(&matched_clauses, &unmatched_clauses) {
Expand Down Expand Up @@ -511,4 +510,9 @@ impl Binder {
}
false
}

// target_only_expr rules:
// we need to find all exprs in matched/unmatched clauses' [AND expr].
// split all exprs which is correlated to target table and push down these
// expr to filter data of target table.
}