Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLS http api tests #1319

Merged
merged 7 commits into from
Aug 6, 2021
Merged

TLS http api tests #1319

merged 7 commits into from
Aug 6, 2021

Conversation

dantengsky
Copy link
Member

@dantengsky dantengsky commented Aug 6, 2021

I hereby agree to the terms of the CLA available at: https://datafuse.rs/policies/cla/

Summary

  • unit test for TLS HTTP API service (Query)
  • rename to tls_server_cert/key to api_tls_server_cert/key
  • move tests/data/certs to tests/certs
  • remove directory $project_root/tls
    • using same certs in UT for both https and tls rpc services

Changelog

  • Improvement

Related Issues

unit test for #1174
Fixes #1318

Test Plan

Unit Tests

Stateless Tests

@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@dantengsky dantengsky changed the title TLS http api tests WIP: TLS http api tests Aug 6, 2021
@BohuTANG
Copy link
Member

BohuTANG commented Aug 6, 2021

Cool 👍
Prefer to remove tls root directory to use tests/data/certs

@BohuTANG
Copy link
Member

BohuTANG commented Aug 6, 2021

For the test certs directory, is it better to tests/certs instead of tests/data/certs?

@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2021

Codecov Report

Merging #1319 (1b079a2) into master (11328c2) will decrease coverage by 0%.
The diff coverage is 57%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1319   +/-   ##
======================================
- Coverage      72%     72%   -1%     
======================================
  Files         478     480    +2     
  Lines       27863   27906   +43     
======================================
+ Hits        20175   20179    +4     
- Misses       7688    7727   +39     
Impacted Files Coverage Δ
fusequery/query/src/api/http_service.rs 0% <0%> (ø)
fusequery/query/src/api/rpc_service.rs 55% <0%> (ø)
fusequery/query/src/api/http_service_test.rs 100% <100%> (ø)
common/datavalues/src/utils.rs 36% <0%> (-7%) ⬇️
fusecli/cli/src/cmds/packages/package.rs 0% <0%> (ø)
fusecli/cli/src/cmds/packages/list.rs 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11328c2...1b079a2. Read the comment docs.

@dantengsky
Copy link
Member Author

For the test certs directory, is it better to tests/certs instead of tests/data/certs?

Ok, I will go with tests/certs

@dantengsky
Copy link
Member Author

Cool
Prefer to remove tls root directory to use tests/data/certs

Ok

@dantengsky dantengsky changed the title WIP: TLS http api tests TLS http api tests Aug 6, 2021
@dantengsky dantengsky marked this pull request as ready for review August 6, 2021 09:05
@databend-bot
Copy link
Member

Hello @dantengsky, 🎉 Thank you for opening the pull request! 🎉
Your pull request state is not in Draft, please add Reviewers or Re-request review again!
FuseQuery: @BohuTANG @sundy-li @zhang2014
FuseStore: @drmingdrmer @dantengsky
Or visit datafuse roadmap for some clues.

@BohuTANG BohuTANG removed the request for review from zhang2014 August 6, 2021 09:12
Copy link
Member

@BohuTANG BohuTANG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you @dantengsky

@databend-bot
Copy link
Member

CI Passed
Reviewer Approved
Let's Merge

@databend-bot databend-bot merged commit dd03f12 into databendlabs:master Aug 6, 2021
@dantengsky dantengsky deleted the fix-1174 branch August 6, 2021 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rename to tls_server_cert/key to api_tls_server_cert/key
4 participants