-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TLS http api tests #1319
TLS http api tests #1319
Conversation
Thanks for the contribution! Please review the labels and make any necessary changes. |
Cool 👍 |
For the test certs directory, is it better to |
Codecov Report
@@ Coverage Diff @@
## master #1319 +/- ##
======================================
- Coverage 72% 72% -1%
======================================
Files 478 480 +2
Lines 27863 27906 +43
======================================
+ Hits 20175 20179 +4
- Misses 7688 7727 +39
Continue to review full report at Codecov.
|
Ok, I will go with |
Ok |
Hello @dantengsky, 🎉 Thank you for opening the pull request! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you @dantengsky
CI Passed |
I hereby agree to the terms of the CLA available at: https://datafuse.rs/policies/cla/
Summary
tls_server_cert/key
toapi_tls_server_cert/key
tests/data/certs
totests/certs
$project_root/tls
Changelog
Related Issues
unit test for #1174
Fixes #1318
Test Plan
Unit Tests
Stateless Tests