Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add storage endpoint check #13550

Merged
merged 7 commits into from
Nov 8, 2023
Merged

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Nov 2, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Add storage endpoint check for s3.


This change is Reviewable

Copy link

vercel bot commented Nov 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
databend ⬜️ Ignored (Inspect) Visit Preview Nov 2, 2023 11:10am

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Nov 2, 2023
@Xuanwo Xuanwo requested a review from youngsofun November 2, 2023 10:26
@Xuanwo Xuanwo enabled auto-merge November 2, 2023 11:10
@youngsofun
Copy link
Member

0: statement is expected to fail with error:
	1005
but got error:
	mysql client error: Server error: `ERROR HY000 (1105): StorageOther. Code: 4000, Text = invalid input parameter (storage params is invalid for it's auto detect failed for InvalidConfig. Code: 2002, Text = s3 endpoint_url http://127.0.0.1:9900/ is invalid or incomplete: reqwest::Error { kind: Request, url: Url { scheme: "http", cannot_be_a_base: false, username: "", password: None, host: Some(Ipv4(127.0.0.1)), port: Some(9900), path: "/", query: None, fragment: None }, source: hyper::Error(Connect, ConnectError("tcp connect error", Os { code: 111, kind: ConnectionRefused, message: "Connection refused" })) }.

<Backtrace disabled by default. Please use RUST_BACKTRACE=1 to enable> ).'
[SQL] create stage tpch100_data url='s3://wubx/tb101' connection=(aws_key_id='minioadmin' aws_secret_key='minioadmin' endpoint_url='http://127.0.0.1:9900/');
at tests/sqllogictests/suites/base/05_ddl/05_0025_ddl_user_stage:7

@Xuanwo Xuanwo marked this pull request as ready for review November 8, 2023 09:33
@Xuanwo Xuanwo enabled auto-merge November 8, 2023 09:33
@Xuanwo Xuanwo added this pull request to the merge queue Nov 8, 2023
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Nov 8, 2023
@BohuTANG BohuTANG merged commit 09edee5 into databendlabs:main Nov 8, 2023
andylokandy pushed a commit to andylokandy/databend that referenced this pull request Nov 27, 2023
* feat: Add storage endpoint check

Signed-off-by: Xuanwo <[email protected]>

* Update src/meta/app/src/storage/storage_params.rs

Co-authored-by: Yang Xiufeng <[email protected]>

* Fix stage test

Signed-off-by: Xuanwo <[email protected]>

* Fix test

Signed-off-by: Xuanwo <[email protected]>

---------

Signed-off-by: Xuanwo <[email protected]>
Co-authored-by: Yang Xiufeng <[email protected]>
@Xuanwo Xuanwo deleted the check-endpoint branch May 9, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants