Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refine enable_compact_after_write, enable_recluster_after_write need deprecated #14114

Merged
merged 1 commit into from
Dec 21, 2023
Merged

chore: refine enable_compact_after_write, enable_recluster_after_write need deprecated #14114

merged 1 commit into from
Dec 21, 2023

Conversation

BohuTANG
Copy link
Member

@BohuTANG BohuTANG commented Dec 21, 2023 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  • use enable_recluster_after_write to control compact is not meaningful, plan to deprecated it in the future
  • add enable_compact_after_write to control the compact after COPY/REPLACEINTO, this including recluster
  • *_auto_compact_after_write to *_need_compact_after_write

Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Covered by exists tests.

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Dec 21, 2023
@BohuTANG BohuTANG requested a review from dantengsky December 21, 2023 13:45
@BohuTANG BohuTANG force-pushed the dev-compact-settings branch 2 times, most recently from f9aacc2 to 6d6176a Compare December 21, 2023 13:56
@BohuTANG BohuTANG force-pushed the dev-compact-settings branch from 6d6176a to 202b73a Compare December 21, 2023 13:57
@BohuTANG BohuTANG marked this pull request as ready for review December 21, 2023 14:06
@BohuTANG BohuTANG added the C-setting-changed Category: setting changed, need note in release label Dec 21, 2023
@BohuTANG
Copy link
Member Author

Label with C-setting-changed, will note in the next stable release.

@BohuTANG BohuTANG merged commit 2b3efe8 into databendlabs:main Dec 21, 2023
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantengsky dantengsky Awaiting requested review from dantengsky

Assignees
No one assigned
Labels
C-setting-changed Category: setting changed, need note in release pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@BohuTANG