Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: open join spilling by default #14843

Merged
merged 5 commits into from
Mar 7, 2024
Merged

chore: open join spilling by default #14843

merged 5 commits into from
Mar 7, 2024

Conversation

xudong963
Copy link
Member

@xudong963 xudong963 commented Mar 5, 2024 •
edited by BohuTANG
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Briefly describe what this PR aims to solve. Include background context that will help reviewers understand the purpose of the PR.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@xudong963 xudong963 marked this pull request as draft March 5, 2024 06:22
@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Mar 5, 2024
@xudong963 xudong963 force-pushed the default_enable_join_spill branch from 1449d30 to 9c52fe6 Compare March 5, 2024 06:23
@xudong963 xudong963 added the ci-benchmark Benchmark: run all test label Mar 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2024

Docker Image for PR

  • tag: pr-14843-40cb87c

note: this image tag is only available for internal use,
please check the internal doc for more details.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2024

ClickBench Report

@xudong963 xudong963 added ci-benchmark Benchmark: run all test and removed ci-benchmark Benchmark: run all test labels Mar 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2024

Docker Image for PR

  • tag: pr-14843-40cb87c

note: this image tag is only available for internal use,
please check the internal doc for more details.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2024

ClickBench Report

@xudong963 xudong963 force-pushed the default_enable_join_spill branch from 9c52fe6 to 8c34756 Compare March 5, 2024 12:50
@xudong963 xudong963 mentioned this pull request Mar 6, 2024
Closed
9 tasks
@xudong963 xudong963 added ci-cloud Build docker image for cloud test and removed ci-benchmark Benchmark: run all test labels Mar 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 6, 2024

Docker Image for PR

  • tag: pr-14843-855dfcd

note: this image tag is only available for internal use,
please check the internal doc for more details.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 6, 2024

ClickBench Report

@xudong963 xudong963 force-pushed the default_enable_join_spill branch from a4edf07 to 6129458 Compare March 6, 2024 12:10
@xudong963 xudong963 added ci-cloud Build docker image for cloud test and removed ci-cloud Build docker image for cloud test labels Mar 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 6, 2024

Docker Image for PR

  • tag: pr-14843-8a322b7

note: this image tag is only available for internal use,
please check the internal doc for more details.

@xudong963 xudong963 force-pushed the default_enable_join_spill branch from 99a756c to 9637af2 Compare March 6, 2024 13:22
@xudong963 xudong963 added ci-cloud Build docker image for cloud test and removed ci-cloud Build docker image for cloud test labels Mar 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 6, 2024

Docker Image for PR

  • tag: pr-14843-d75b399

note: this image tag is only available for internal use,
please check the internal doc for more details.

@xudong963
Copy link
Member Author

Let's make join spilling open by default!

@xudong963 xudong963 marked this pull request as ready for review March 7, 2024 02:18
@xudong963 xudong963 changed the title chore: try to open join spilling by default chore: open join spilling by default Mar 7, 2024
@xudong963 xudong963 added the ci-benchmark Benchmark: run all test label Mar 7, 2024
Dousir9
Dousir9 approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@Dousir9 Dousir9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, LGTM !

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024

Docker Image for PR

  • tag: pr-14843-7ca56f1

note: this image tag is only available for internal use,
please check the internal doc for more details.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024

ClickBench Report

@xudong963 xudong963 force-pushed the default_enable_join_spill branch from 96057f7 to 0b6cbd0 Compare March 7, 2024 06:39
@xudong963 xudong963 enabled auto-merge March 7, 2024 06:39
@xudong963 xudong963 added this pull request to the merge queue Mar 7, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Mar 7, 2024
@BohuTANG BohuTANG merged commit 4b65600 into databendlabs:main Mar 7, 2024
71 checks passed
@xudong963 xudong963 deleted the default_enable_join_spill branch March 7, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BohuTANG BohuTANG BohuTANG left review comments

@Dousir9 Dousir9 Dousir9 approved these changes

@zhang2014 zhang2014 zhang2014 approved these changes

Assignees
No one assigned
Labels
ci-benchmark Benchmark: run all test ci-cloud Build docker image for cloud test pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xudong963 @BohuTANG @zhang2014 @Dousir9