Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add show views & desc view #14926

Merged
merged 9 commits into from
Mar 20, 2024
Merged

feat: add show views & desc view #14926

merged 9 commits into from
Mar 20, 2024

Conversation

blackstar-baba
Copy link
Contributor

@blackstar-baba blackstar-baba commented Mar 13, 2024 •
edited by TCeason
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

add features show views and desc view

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@blackstar-baba blackstar-baba changed the title add show views & desc view feat:add show views & desc view Mar 13, 2024
@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Mar 13, 2024
@blackstar-baba blackstar-baba changed the title feat:add show views & desc view feat: add show views & desc view Mar 13, 2024
@blackstar-baba blackstar-baba marked this pull request as draft March 13, 2024 04:36
@blackstar-baba blackstar-baba marked this pull request as ready for review March 14, 2024 04:54
@BohuTANG BohuTANG requested a review from TCeason March 14, 2024 05:00
@BohuTANG
Copy link
Member

Good job 👍

Better to add a logic test like show tables here: https://github.com/datafuselabs/databend/blob/9f3bdda2e69d0ed5f502a6efbf9b7e025598c344/tests/sqllogictests/suites/base/06_show/06_0004_show_tables.test

@TCeason TCeason requested a review from flaneur2020 March 14, 2024 05:18
TCeason
TCeason approved these changes Mar 17, 2024
View reviewed changes
Copy link
Collaborator

@TCeason TCeason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Binder and privilege is LGTM.

@TCeason TCeason requested a review from andylokandy March 18, 2024 01:50
andylokandy
andylokandy approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@andylokandy andylokandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the parser part.

@TCeason TCeason enabled auto-merge March 19, 2024 00:43
auto-merge was automatically disabled March 20, 2024 00:42

Head branch was pushed to by a user without write access

@blackstar-baba
Copy link
Contributor Author

@BohuTANG PTAL

@BohuTANG BohuTANG merged commit c4dcf91 into databendlabs:main Mar 20, 2024
72 checks passed
@BohuTANG
Copy link
Member

@blackstar-baba Thanks for your great contribution!

@BohuTANG
Copy link
Member

@soyeric128 Could you please add a doc for this PR? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundy-li sundy-li sundy-li left review comments

@BohuTANG BohuTANG BohuTANG left review comments

@TCeason TCeason TCeason approved these changes

@andylokandy andylokandy andylokandy approved these changes

@flaneur2020 flaneur2020 Awaiting requested review from flaneur2020

Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: show views and desc view
6 participants
@blackstar-baba @BohuTANG @flaneur2020 @sundy-li @andylokandy @TCeason