chore: tweak deletion batch size & log messages #15005
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
remove_file_in_batch
Instead of setting a fixed batch size of 1000 for file deletion, adjust the batch size based on the
max_threads
setting to allow for more parallel deletion of files, i.e. take "(number of files) / max_threads" as the size of batch.In latency-sensitive scenarios, adjusting the batch size of object storage file deletion, may improve performance significantly:
before this PR (with customized log)
ec2 query node + s3 in the same region
with this PR:
logs(info level) the time used in logical plan and binding phase
Fixes #[Link the issue here]
Tests
Type of change