Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add buffer for spiller #15021

Merged
merged 1 commit into from
Mar 20, 2024
Merged

feat: add buffer for spiller #15021

merged 1 commit into from
Mar 20, 2024

Conversation

xudong963
Copy link
Member

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Briefly describe what this PR aims to solve. Include background context that will help reviewers understand the purpose of the PR.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Mar 19, 2024
@xudong963 xudong963 marked this pull request as draft March 19, 2024 10:08
@xudong963 xudong963 added the ci-cloud Build docker image for cloud test label Mar 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-15021-79a93b7

note: this image tag is only available for internal use,
please check the internal doc for more details.

@xudong963 xudong963 marked this pull request as ready for review March 20, 2024 06:35
@xudong963 xudong963 requested review from zhang2014 and Dousir9 March 20, 2024 06:35
@xudong963 xudong963 added this pull request to the merge queue Mar 20, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Mar 20, 2024
@BohuTANG BohuTANG merged commit 31a63b1 into databendlabs:main Mar 20, 2024
75 checks passed
@xudong963 xudong963 deleted the spiller_cache branch March 20, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhang2014 zhang2014 zhang2014 approved these changes

@Dousir9 Dousir9 Dousir9 approved these changes

Assignees
No one assigned
Labels
ci-cloud Build docker image for cloud test pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: add a buffer to Spiller
4 participants
@xudong963 @zhang2014 @Dousir9 @BohuTANG