Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(query): support domain contains in string type #15023

Merged
merged 4 commits into from
Mar 20, 2024

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Mar 19, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

support domain contains in string type

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Mar 19, 2024
@sundy-li sundy-li requested review from andylokandy and leiysky March 19, 2024 12:51
@sundy-li sundy-li changed the title feat(query): support domain contains in string type chore(query): support domain contains in string type Mar 19, 2024
@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Mar 19, 2024
@sundy-li
Copy link
Member Author

mysql> select min(counterid), max(counterid) from hits;
+----------------+----------------+
| min(counterid) | max(counterid) |
+----------------+----------------+
|             17 |         262115 |
+----------------+----------------+
1 row in set (4.90 sec)
Read 99997497 rows, 381.46 MiB in 4.860 sec., 20.58 million rows/sec., 78.49 MiB/sec.

mysql> explain select counterid from hits where counterid in (1,32,3,2453,5,435,4,54,645,65,65,6,5,65, 434,43,4,3,43,4,3,4,3,43,4,3,43);
+-------------------------------------------------------------------------------------------------------------------------------------+
| explain                                                                                                                             |
+-------------------------------------------------------------------------------------------------------------------------------------+
| TableScan                                                                                                                           |
| ├── table: default.default.hits                                                                                                     |
| ├── output columns: [counterid (#6)]                                                                                                |
| ├── read rows: 17294727                                                                                                             |
| ├── read bytes: 246878                                                                                                              |
| ├── partitions total: 761                                                                                                           |
| ├── partitions scanned: 133                                                                                                         |
| ├── pruning stats: [segments: <range pruning: 1 to 1>, blocks: <range pruning: 761 to 133, bloom pruning: 0 to 0>]                  |
| ├── push downs: [filters: [contains([1, 32, 3, 2453, 5, 435, 4, 54, 645, 65, 6, 434, 43], hits.counterid (#6))], limit: NONE]       |
| └── estimated rows: 19999499.40                                                                                                     |
+-------------------------------------------------------------------------------------------------------------------------------------+
10 rows in set (4.29 sec)
Read 0 rows, 0.00 B in 4.236 sec., 0 rows/sec., 0.00 B/sec.

@sundy-li sundy-li marked this pull request as ready for review March 19, 2024 13:02
@sundy-li sundy-li enabled auto-merge March 20, 2024 00:48
@sundy-li sundy-li added this pull request to the merge queue Mar 20, 2024
Merged via the queue into databendlabs:main with commit 2f64773 Mar 20, 2024
72 checks passed
@sundy-li sundy-li deleted the domain-contains branch March 20, 2024 01:39
yufan022 pushed a commit to yufan022/databend that referenced this pull request Apr 16, 2024
)

* feat(query): support domain contains in string type

* feat(query): support domain contains in string type

* add random tests
yufan022 pushed a commit to yufan022/databend that referenced this pull request Apr 16, 2024
)

* feat(query): support domain contains in string type

* feat(query): support domain contains in string type

* add random tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles. pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants