-
Notifications
You must be signed in to change notification settings - Fork 761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support pagination on task_history #15047
feat: support pagination on task_history #15047
Conversation
We should make it works:) Think a user has many tasks all scheduler is in 1 second, the rows is very large, and run: So, here the better way is:
|
first limitation is easy to limit on server side, but for the second part, we need the push_down_info struct to pass limit number to the storage table source, but for now it does not work |
This limitation is ok if we give a default number for it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Previously when single request return body is large, it would show grpc error, this Pull Request support the following things:
task_name
,schedule_time
filter push down, allow to use those select information to filter unneeded rows on cloud control services.next_page_token
andpage_size
parameter, allow to control page size and pagination of the single request.NOTICE
: I also tried to use limit push_down, but found that it does NOT work, need some deep dive on the issuefix #14929
Tests
Type of change