Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(query): remove metrics if moved to the profile #15054

Merged
merged 4 commits into from
Mar 21, 2024

Conversation

zhang2014
Copy link
Member

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

refactor(query): remove metrics if moved to the profile

  • Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

@zhang2014 zhang2014 requested a review from BohuTANG March 21, 2024 04:39
@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Mar 21, 2024
@BohuTANG
Copy link
Member

Logic tests also need to fix:

--- /runner/_work/databend/databend/tests/suites/0_stateless/20+_others/20_0014_sort_spill.result	2024-03-21 04:51:31.455574726 +0000
+++ /runner/_work/databend/databend/tests/suites/0_stateless/20+_others/20_0014_sort_spill.stdout	2024-03-21 04:54:21.183548660 +0000
@@ -3,10 +3,6 @@
 1
 NULL
 ===================
-transform_spill_write_count_total	{"spill":"sort_spill"}	2.0
-transform_spill_write_bytes_total	{"spill":"sort_spill"}	2336.0
-transform_spill_read_count_total	{"spill":"sort_spill"}	2.0
-transform_spill_read_bytes_total	{"spill":"sort_spill"}	2336.0
 ===================

@zhang2014 zhang2014 enabled auto-merge March 21, 2024 05:34
@zhang2014 zhang2014 added this pull request to the merge queue Mar 21, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Mar 21, 2024
@BohuTANG BohuTANG merged commit d31c14b into databendlabs:main Mar 21, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants