Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: privilege check for insert statement #15075

Merged
merged 4 commits into from
Mar 23, 2024

Conversation

SkyFan2002
Copy link
Member

@SkyFan2002 SkyFan2002 commented Mar 23, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

To use the OVERWRITE option on INSERT, you must use a role that has DELETE privilege on the table because OVERWRITE will delete the existing records in the table.

  • Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Mar 23, 2024
@SkyFan2002 SkyFan2002 requested a review from TCeason March 23, 2024 05:01
@BohuTANG
Copy link
Member

Good to have a SQL logic test to check the new privilege, and to protect someone break this in the future.

Copy link
Collaborator

@TCeason TCeason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SkyFan2002 SkyFan2002 marked this pull request as draft March 23, 2024 05:49
@SkyFan2002 SkyFan2002 marked this pull request as ready for review March 23, 2024 07:29
@SkyFan2002 SkyFan2002 enabled auto-merge March 23, 2024 07:29
@SkyFan2002 SkyFan2002 added this pull request to the merge queue Mar 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 23, 2024
@BohuTANG BohuTANG merged commit 171ada8 into databendlabs:main Mar 23, 2024
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants