Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix plan_sql error can not write query_log #15077

Merged
merged 1 commit into from
Mar 23, 2024

Conversation

BohuTANG
Copy link
Member

@BohuTANG BohuTANG commented Mar 23, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

There are two steps to execute a query:

  1. Plan the SQL -- here error we can not write query_log
  2. Execute the plan -- interpreter

This PR add a new function: interpreter_plan_sql, it's a wrap of plan_sql, If plan_sql error occurs, we will log the query start and finished.

Where is use interpreter_plan_sql:

  1. http handler
  2. ClickHouse handler
  3. MySQL handler
  4. suggested_background_tasks.rs

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Mar 23, 2024
@BohuTANG BohuTANG marked this pull request as ready for review March 23, 2024 11:31
@BohuTANG BohuTANG requested review from sundy-li and ZhiHanZ March 23, 2024 11:31
@BohuTANG BohuTANG merged commit ebaf2ba into databendlabs:main Mar 23, 2024
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: leave a record with empty query_text when planning fail.
2 participants