refactor: QueryFragmentsPlanPacket should include just setting changes
#15095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-refactor
drmingdrmer
force-pushed
the
31-settings
branch
from
b155ac5 to
8b68f10
Compare
There is no need to have the entire `Settings` in `QueryFragmentsPlanPacket`. Only the `Settings.changes` is used. And `Settings.tenant` can not be `serde` in future, ths `QueryFragmentsPlanPacket` can not include a `Tenant` in it. - Part of databendlabs#14719
drmingdrmer
force-pushed
the
31-settings
branch
from
8b68f10 to
f17f793
Compare
29 tasks
zhang2014
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
refactor:
QueryFragmentsPlanPacketshould include just setting changesThere is no need to have the entire
SettingsinQueryFragmentsPlanPacket.Only the
Settings.changesis used.And
Settings.tenantcan not beserdein future, thsQueryFragmentsPlanPacketcan not include aTenantin it.Tests
Type of change
Related Issues