Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(query): add query_result_cache_min_execute_secs #15101

Merged
merged 3 commits into from
Mar 27, 2024
Merged

feat(query): add query_result_cache_min_execute_secs #15101

merged 3 commits into from
Mar 27, 2024

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Mar 27, 2024 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  1. add query_result_cache_min_execute_secs settings. For a query to be cached, it must take at least this many seconds to fetch the first block. It helps to avoid caching queries that are too fast to execute or queries with streaming scan.

  2. Increase wait_time_secs to be 10 secs.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Mar 27, 2024
@sundy-li sundy-li added this pull request to the merge queue Mar 27, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Mar 27, 2024
@BohuTANG BohuTANG merged commit 3d52b3e into databendlabs:main Mar 27, 2024
78 checks passed
@github-actions github-actions bot mentioned this pull request May 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RinChanNOWWW RinChanNOWWW RinChanNOWWW left review comments

@youngsofun youngsofun youngsofun approved these changes

@zhang2014 zhang2014 Awaiting requested review from zhang2014

Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

increase default_wait_time_secs to be 10 secs
4 participants
@sundy-li @youngsofun @RinChanNOWWW @BohuTANG