Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(query): implement st_geometryfromewkb function #15118

Merged
merged 9 commits into from
Mar 29, 2024

Conversation

kkk25641463
Copy link
Contributor

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Support snowflake st_geometryfromewkb() function.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Mar 28, 2024
Copy link

what-the-diff bot commented Mar 28, 2024

PR Summary

  • Geozero Crate Addition
    A new feature has been added to the 'geozero' crate in the Cargo.toml file, this enhances the functionality of our application by providing additional capabilities.

  • Additional Data Types in geometry.rs
    New data types like databend_common_expression::types::BinaryType, geozero::GeozeroGeometry, and geozero::ToGeos have been introduced in geometry.rs. These data types are essential for improved geometry processing and operations.

  • Alias Registration for st_geometryfromwkb
    Aliases for the st_geometryfromwkb function have been registered in the register function. These alternative names improve code clarity and maintainability by providing familiar or more descriptive names for the function.

  • Passthrough Nullable Function Registration
    Passthrough nullable functions for st_geometryfromwkb have been registered in the register function. These are special functions that allow our code to handle cases where some data may be undefined or not available, increasing the robustness of our production environment.

  • ST_GeometryFromWKB Test Addition
    A new test for the st_geometryfromwkb function has been added in geometry.rs. This will help ensure our code is working correctly, reducing the possibility of unexpected behaviors or bugs.

  • Updates to Test Data Files
    The test data files, function_list.txt and geometry.txt in testdata, have been modified as part of the above changes. These changes allow them to reflect the aforementioned modifications, ensuring our tests are up-to-date with the current state of the code.

@ariesdevil ariesdevil self-requested a review March 29, 2024 02:56
Copy link
Contributor

@ariesdevil ariesdevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@BohuTANG BohuTANG merged commit 29f6bde into databendlabs:main Mar 29, 2024
72 checks passed
@BohuTANG
Copy link
Member

Great!
Thanks for your contribution. @kkk25641463

@kkk25641463 kkk25641463 deleted the ST_GEOMETRYFROMWKB branch March 29, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants