refactor: replace String with Tenant #15119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replacing all String with Tenant introduces a lot changes. These changes will be split into several PRs. This is one of them. - Part of databendlabs#14719
github-actions
bot
added
the
pr-refactor
29 tasks
andylokandy
reviewed
Mar 28, 2024
| @@ -3611,18 +3612,30 @@ pub fn create_database_option(i: Input) -> IResult<CreateDatabaseOption> { | |||
| rule! { | |||
| FROM ~ SHARE ~ #ident ~ "." ~ #ident | |||
| }, | |||
| |(_, _, tenant, _, share_name)| { | |||
| |(_x, _y, tenant, _z, share_name)| { | |||
Comment on lines
+3617
to
+3618
| // TODO: non-safe new() that does not return an error | ||
| tenant: Tenant::new(tenant.to_string()), |
There was a problem hiding this comment.
You can use map_res to return an error.
Comment on lines
+3629
to
+3638
| if let CreateDatabaseOption::FromShare(ident) = &opt { | ||
| if ident.tenant.name().is_empty() { | ||
| return Err(nom::Err::Error(Error::from_error_kind( | ||
| i, | ||
| ErrorKind::Other("tenant is empty string"), | ||
| ))); | ||
| } | ||
| } | ||
|
|
||
| Ok((i, opt)) |
|
@andylokandy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
refactor: replace String with Tenant
Replacing all String with Tenant introduces a lot changes.
These changes will be split into several PRs.
This is one of them.
Tests
Type of change
Related Issues
This change is