Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): new agg hashtable hung with little data on singleton #15140

Merged
merged 6 commits into from
Apr 1, 2024
Merged

fix(query): new agg hashtable hung with little data on singleton #15140

merged 6 commits into from
Apr 1, 2024

Conversation

Freejww
Copy link
Contributor

@Freejww Freejww commented Mar 31, 2024 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

1.fix pipeline bug on singleton with only one input on new_transform_partition_bucket.
2.add sqllogical tests for new agg hashtable.

  • Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

@Freejww Freejww added the ci-cloud Build docker image for cloud test label Mar 31, 2024
@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Mar 31, 2024
@github-actions GitHub Actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-15140-0cb2cb1

note: this image tag is only available for internal use,
please check the internal doc for more details.

@Freejww Freejww marked this pull request as draft March 31, 2024 06:45
@Freejww Freejww changed the title chore(query): new agg hashtable perf test fix(query): new agg hashtable hung with little data on singleton Mar 31, 2024
@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Mar 31, 2024
@Freejww Freejww marked this pull request as ready for review March 31, 2024 11:44
@Freejww Freejww removed the pr-chore this PR only has small changes that no need to record, like coding styles. label Mar 31, 2024
@Freejww Freejww requested a review from sundy-li April 1, 2024 03:26
@Freejww Freejww added this pull request to the merge queue Apr 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 1, 2024
@BohuTANG BohuTANG merged commit e402065 into databendlabs:main Apr 1, 2024
72 checks passed
@Freejww Freejww deleted the perf branch April 3, 2024 01:51
@github-actions github-actions bot mentioned this pull request Apr 18, 2024
Closed
yufan022 pushed a commit to yufan022/databend that referenced this pull request Jun 18, 2024
@Freejww @yufan022
fix(query): new agg hashtable hung with little data on singleton (dat…
f2e7502 
…abendlabs#15140)

* test

* fix single input on singleton

* add distinct combinator

* revert

* add sqllogical tests

---------

Co-authored-by: jw <[email protected]>
yufan022 pushed a commit to yufan022/databend that referenced this pull request Jun 18, 2024
@Freejww @yufan022
fix(query): new agg hashtable hung with little data on singleton (dat…
07bf59f 
…abendlabs#15140)

* test

* fix single input on singleton

* add distinct combinator

* revert

* add sqllogical tests

---------

Co-authored-by: jw <[email protected]>
(cherry picked from commit e402065)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundy-li sundy-li sundy-li approved these changes

Assignees
No one assigned
Labels
ci-cloud Build docker image for cloud test pr-bugfix this PR patches a bug in codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Freejww @sundy-li @BohuTANG