-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(query): implement ST_GEOMFROMGEOHASH #15156
Conversation
@ariesdevil help me to check plz. |
Can we add another register seems it's limited by geohash crate. |
That's a little complicated, we do not decide to address that. |
The pr depends on geohash algorithm which only support less than 12 precision and is not maintenance by maintainer. Algorithms that support arbitrary precision require rewriting most of code in geohash decode_bbox() function which are break changes. And 12 bit accuracy can meet most geo application needs. |
Is this the reason of the work to maintain the geozero library? |
Part of, another consideration is that we don't want to introduce too much datatypes in |
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
feat: Implement st_geompointfromgeohash()
Currently the precision only implement within 12 digits. And I found that ST_GEOMFROMGEOHASH() returned value is geojson type.
I'm not sure whether we should implement subtypes with geometry type like number type or decimal type? And output can be choose with subtypes like ewkb、ewkt、geojson, otherwise i have to check types by alot of match case in display logic.
see alse try_to_ geometry.
Tests
Type of change