Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix window plan in lazy topn #15165

Merged
merged 5 commits into from
Apr 3, 2024
Merged

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Apr 3, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

fix window plan in lazy topn

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Apr 3, 2024
@sundy-li sundy-li requested review from ariesdevil and b41sh April 3, 2024 10:27
@sundy-li
Copy link
Member Author

sundy-li commented Apr 3, 2024

I found better way to handle this, see the lastest commit.

@BohuTANG BohuTANG merged commit b8f445b into databendlabs:main Apr 3, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Unable to get field named "5". Valid fields: ["2", "3", "10"]
4 participants