Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(planner): push down not in filter expression #15168

Merged
merged 8 commits into from
Apr 8, 2024

Conversation

Dousir9
Copy link
Member

@Dousir9 Dousir9 commented Apr 4, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

NOT is a logical expression that often appears in predicate conditions, in the previous FilterExecutor implementation, the NOT expression would block ByPass(short-circuit) execution optimization, this PR proposes a method to push down NOT for better leveraging ByPass optimization.

SelectExpr(main branch)

截屏2024-04-04 15 57 44

SelectExpr(push down not)

截屏2024-04-04 15 47 51

Refine FilterExecutor Unit-Test

Add Not(Box<PredicateNode>) to PredicateNode Enum to randomly generate NOT expressions(The probability of generating a Not node is 5%).

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Apr 4, 2024
@Dousir9 Dousir9 marked this pull request as ready for review April 7, 2024 07:26
@Dousir9 Dousir9 added this pull request to the merge queue Apr 8, 2024
Merged via the queue into databendlabs:main with commit 31dfd65 Apr 8, 2024
75 checks passed
@Dousir9 Dousir9 deleted the push_down_not_in_filter_expr branch April 8, 2024 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants