refactor: simplify DatabaseFactory, just static dispatch
#15203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-refactor
BohuTANG
approved these changes
Apr 10, 2024
drmingdrmer
force-pushed
the
41-db-create
branch
3 times, most recently
from
34ec519 to
8d55167
Compare
sundy-li
reviewed
Apr 10, 2024
src/bendpy/Cargo.toml
Outdated
| @@ -12,7 +12,7 @@ pyo3-build-config = "0.18.3" | |||
| # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html | |||
| [lib] | |||
| name = "databend" | |||
| crate-type = ["cdylib"] | |||
| crate-ype = ["cdylib"] | |||
drmingdrmer
force-pushed
the
41-db-create
branch
from
8d55167 to
425d51b
Compare
This methods is a transitional method, to build a Tenant from a NonEmptyString. This method will be removed in future because a Tenant must contain a in-meta-service per-tenant config to work correctly, e.g., determine the version of path to store a value: with tenant prefix or without.
drmingdrmer
force-pushed
the
41-db-create
branch
from
425d51b to
0bfdd07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
refactor: simplify
DatabaseFactory, just static dispatchTests
Type of change
Related Issues