-
Notifications
You must be signed in to change notification settings - Fork 761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(query): implement ST_ASGEOJSON #15214
Conversation
Signed-off-by: Fan Yang <[email protected]>
1bdb22e
to
aff26f2
Compare
affd4ec
to
76fbdd6
Compare
Signed-off-by: Fan Yang <[email protected]>
76fbdd6
to
371ceae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a new version and corresponding test if protobuf message format changed:
// Dear developer:
// If you're gonna add a new metadata version, you'll have to add a test for it.
// You could just copy an existing test file(e.g., `../tests/it/v024_table_meta.rs`)
// and replace two of the variable `bytes` and `want`.
Reviewed all commit messages.
Reviewable status: 0 of 35 files reviewed, 1 unresolved discussion (waiting on @b41sh)
OK, i will add it later! |
Signed-off-by: Fan Yang <[email protected]>
# Conflicts: # src/query/settings/src/settings_default.rs # src/query/settings/src/settings_getter_setter.rs
Signed-off-by: Fan Yang <[email protected]> # Conflicts: # src/query/settings/src/settings_default.rs # src/query/settings/src/settings_getter_setter.rs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The protobuf and meta part is great to me
Reviewed 9 of 34 files at r2, 2 of 8 files at r3, 3 of 5 files at r4.
Reviewable status: 14 of 38 files reviewed, 1 unresolved discussion (waiting on @b41sh)
Signed-off-by: Fan Yang <[email protected]>
Signed-off-by: Fan Yang <[email protected]>
Signed-off-by: Fan Yang <[email protected]>
# Conflicts: # src/query/formats/src/field_encoder/values.rs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your great contribution. @kkk25641463
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
feat: Implement ST_ASGEOJSON().
see alse doc.
Tests
Type of change
This change is