Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(query): implement ST_ASGEOJSON #15214

Merged
merged 14 commits into from
Apr 22, 2024
Merged

Conversation

kkk25641463
Copy link
Contributor

@kkk25641463 kkk25641463 commented Apr 11, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

feat: Implement ST_ASGEOJSON().
see alse doc.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Apr 11, 2024
@kkk25641463 kkk25641463 changed the title feat(query): implement ST_MAKEPOLYGON feat(query): implement ST_ASGEOJSON Apr 11, 2024
Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a new version and corresponding test if protobuf message format changed:

    // Dear developer:
    //      If you're gonna add a new metadata version, you'll have to add a test for it.
    //      You could just copy an existing test file(e.g., `../tests/it/v024_table_meta.rs`)
    //      and replace two of the variable `bytes` and `want`.

https://github.com/drmingdrmer/databend/blob/f9d2b79400bf5939bd5308451470c62bb917db9d/src/meta/proto-conv/src/util.rs#L120

Reviewed all commit messages.
Reviewable status: 0 of 35 files reviewed, 1 unresolved discussion (waiting on @b41sh)

@kkk25641463
Copy link
Contributor Author

kkk25641463 commented Apr 19, 2024

Add a new version and corresponding test if protobuf message format changed:

    // Dear developer:
    //      If you're gonna add a new metadata version, you'll have to add a test for it.
    //      You could just copy an existing test file(e.g., `../tests/it/v024_table_meta.rs`)
    //      and replace two of the variable `bytes` and `want`.

https://github.com/drmingdrmer/databend/blob/f9d2b79400bf5939bd5308451470c62bb917db9d/src/meta/proto-conv/src/util.rs#L120

Reviewed all commit messages.
Reviewable status: 0 of 35 files reviewed, 1 unresolved discussion (waiting on @b41sh)

OK, i will add it later!

@kkk25641463 kkk25641463 reopened this Apr 19, 2024
# Conflicts:
#	src/query/settings/src/settings_default.rs
#	src/query/settings/src/settings_getter_setter.rs
Signed-off-by: Fan Yang <[email protected]>

# Conflicts:
#	src/query/settings/src/settings_default.rs
#	src/query/settings/src/settings_getter_setter.rs
@kkk25641463 kkk25641463 requested a review from drmingdrmer April 19, 2024 06:20
Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The protobuf and meta part is great to me

Reviewed 9 of 34 files at r2, 2 of 8 files at r3, 3 of 5 files at r4.
Reviewable status: 14 of 38 files reviewed, 1 unresolved discussion (waiting on @b41sh)

Copy link
Member

@b41sh b41sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your great contribution. @kkk25641463

@BohuTANG BohuTANG merged commit d21a3b9 into databendlabs:main Apr 22, 2024
72 of 73 checks passed
@kkk25641463 kkk25641463 deleted the ST_ASGEOJSON branch April 22, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants