refactor: Extract kvapi::KeyCodec trait from kvapi::Key
#15262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-refactor
drmingdrmer
force-pushed
the
49-remove-string-as-key
branch
from
7524d40 to
1f4adc1
Compare
zhyass
approved these changes
Apr 19, 2024
drmingdrmer
force-pushed
the
49-remove-string-as-key
branch
from
1f4adc1 to
3b43633
Compare
lichuang
approved these changes
Apr 19, 2024
The `kvapi::Key` trait encompasses various key behaviors, including prefix, parent, and value type. The key codec functionality, responsible for encoding and decoding components of a key, operates independently of these behaviors. This is evident in scenarios like a database identifier `(tenant, db_name)`, where `db_name` requires its own distinct codec logic independent of the overarching key structure. This commit introduces the `kvapi::KeyCodec` trait, which abstracts the codec functionality with two primary methods: `encode_key()` and `decode_key()`. This separation enhances modularity and aligns with single responsibility principles, allowing for more targeted implementations and testing of key encoding and decoding behaviors.
drmingdrmer
force-pushed
the
49-remove-string-as-key
branch
from
3b43633 to
9f4f9d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
refactor: Extract
kvapi::KeyCodectrait fromkvapi::KeyThe
kvapi::Keytrait encompasses various key behaviors, includingprefix, parent, and value type. The key codec functionality,
responsible for encoding and decoding components of a key, operates
independently of these behaviors. This is evident in scenarios like a
database identifier
(tenant, db_name), wheredb_namerequires itsown distinct codec logic independent of the overarching key structure.
This commit introduces the
kvapi::KeyCodectrait, which abstracts thecodec functionality with two primary methods:
encode_key()anddecode_key(). This separation enhances modularity and aligns withsingle responsibility principles, allowing for more targeted
implementations and testing of key encoding and decoding behaviors.
Tests
Type of change
Related Issues
This change is