Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: insert Plan should not have schema. #15330

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

youngsofun
Copy link
Member

@youngsofun youngsofun commented Apr 24, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

as a convention in this project, the schema of a specific Plan should be the schema of output.

  • Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Apr 24, 2024
@youngsofun youngsofun requested a review from sundy-li April 24, 2024 14:48
@youngsofun youngsofun marked this pull request as draft April 24, 2024 15:47
@youngsofun youngsofun marked this pull request as ready for review April 24, 2024 16:10
@BohuTANG BohuTANG merged commit 29407ce into databendlabs:main Apr 25, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants