Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(query): add merge ratio in sort spill #15332

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Apr 25, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

add merge ratio in sort spill

  • Fixes #[Link the issue here]

This query is working now

🐳 :) set sort_spilling_memory_ratio = 60;
🐳 :) select referer,params from hits order by referer,params ignore_result;
0 row read in 78.471 sec. Processed 100 million row, 7.72 GiB (1.27 million row/s, 100.76 MiB/s)

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Apr 25, 2024
@xudong963 xudong963 added the ci-benchmark Benchmark: run all test label Apr 25, 2024
Copy link
Contributor

@RinChanNOWWW RinChanNOWWW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

Docker Image for PR

  • tag: pr-15332-4637f60

note: this image tag is only available for internal use,
please check the internal doc for more details.

@BohuTANG BohuTANG merged commit 3ab7aaf into databendlabs:main Apr 25, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-benchmark Benchmark: run all test pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants