Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(query): support with clause in copy into #15343

Merged
merged 3 commits into from
Apr 26, 2024
Merged

feat(query): support with clause in copy into #15343

merged 3 commits into from
Apr 26, 2024

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Apr 26, 2024 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

feat(query): support with clause in copy into

  • Fixes #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@sundy-li sundy-li requested a review from youngsofun April 26, 2024 00:43
@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Apr 26, 2024
@sundy-li sundy-li requested review from xudong963 and Dousir9 April 26, 2024 00:43
Dousir9
Dousir9 approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@Dousir9 Dousir9 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM.

@xudong963 xudong963 enabled auto-merge April 26, 2024 01:51
@xudong963 xudong963 added this pull request to the merge queue Apr 26, 2024
Merged via the queue into databendlabs:main with commit 88331f0 Apr 26, 2024
72 checks passed
@xudong963 xudong963 deleted the copy-with branch April 26, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dousir9 Dousir9 Dousir9 approved these changes

@xudong963 xudong963 xudong963 approved these changes

@youngsofun youngsofun youngsofun approved these changes

Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sundy-li @youngsofun @xudong963 @Dousir9